feat: select ring buffer topics by message type#3
Merged
Conversation
- topic_filter.py: extend find_matching_config with optional type_name parameter; entries with a 'type' key are matched by exact message type, entries with a 'pattern' key by name glob, both keys AND-ed together - ringbuffer_node.py: pass type_names[0] to find_matching_config so type-based config entries are evaluated during topic discovery - example_config.yaml: add geometry_msgs/msg/Twist type-selector example - test_topic_filter.py: 11 new tests covering type-only, combined, and edge-case matching scenarios Co-authored-by: marc-hanheide <1153084+marc-hanheide@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to select topics by type for recording
feat: select ring buffer topics by message type
Mar 12, 2026
marc-hanheide
marked this pull request as ready for review
March 12, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topics could only be matched by name/glob pattern. This adds type-based selection so entries like
type: "geometry_msgs/msg/Twist"record all topics of that type regardless of their name. The node's existing periodic discovery loop picks up newly published topics automatically.Changes
topic_filter.py–find_matching_configgains an optionaltype_nameparameter. Config entries now support:pattern– existing Zenoh glob on topic nametype– exact message type matchringbuffer_node.py– passestype_names[0]tofind_matching_configduring discoveryexample_config.yaml– documents the newtypekey with ageometry_msgs/msg/Twistexampletest_topic_filter.py– 11 new tests covering type-only, combined, and edge-case scenariosExample config
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.